Driveby cleanups #561
Merged
Driveby cleanups #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
2502-cleanups
branch
from
db30835 to
ac0d217
Compare
cdecker
previously approved these changes
Jan 20, 2025
cdecker
force-pushed
the
2502-cleanups
branch
from
ac0d217 to
763b770
Compare
cdecker
force-pushed
the
2502-cleanups
branch
from
763b770 to
cd06055
Compare
The `nodelet` and the `plugin` were using an absolute path, which would get clobbered by concurrent tests, which can then lead to spurious fails. Using relative paths makes this much more stable.
Previously, the deserialization logic called `Promise::new` twice, once in a temp variable and again for the final return. This commit removes the unused temorary assignement. Signed-off-by: Peter Neuroth <[email protected]>
Signed-off-by: Peter Neuroth <[email protected]>
Cargo complaints about the unused fields in `UdsConnectInfo`. Currently the `UnixStream` in this file really seems to be unused but I assume that it is going to be needed in the future. Signed-off-by: Peter Neuroth <[email protected]>
cdecker
force-pushed
the
2502-cleanups
branch
from
cd06055 to
96df147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some some cleanups that resolve some warnings that
cargocomplaint about.